Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasm name section output format #388

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

thegu5
Copy link
Contributor

@thegu5 thegu5 commented Dec 8, 2024

Adds function and parameter names for wasm debuggers (chrome devtools, etc). There are still issues with parameter names - maybe because of compiler optimizations or extra conditions for MethodInfo? It can be added to the original binary by concatenating the two together. More information can be found in the comments.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12217941886

Details

  • 2 of 88 (2.27%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 28.18%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Cpp2IL.Core/OutputFormats/WasmNameSectionOutputFormat.cs 1 87 1.15%
Totals Coverage Status
Change from base Build 12074790339: -0.2%
Covered Lines: 3385
Relevant Lines: 10267

💛 - Coveralls

@SamboyCoding SamboyCoding merged commit edbb994 into SamboyCoding:development Dec 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants